Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont display empty prompt buttons #7543

Closed
wants to merge 1 commit into from
Closed

dont display empty prompt buttons #7543

wants to merge 1 commit into from

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Jul 13, 2024

This isn't a great fix, because I still have no clue how empty options end up in the prompt state, but at the very least this is a stopgap.

Honestly, if somebody else can spy a reason for there to be some extra entries in the prompt state, they're better at inspecting code than I am 😂

It adds a test, but that test was just to determine that the issue was actually on the frontend and not the backend (still, doesn't hurt).

Closes #7424

@NoahTheDuke
Copy link
Collaborator

yeah something fucky is happening here. i suspect it's in trigger-queued-event-player:

          choices-map (map #(vector (or (:ability-name (:ability (:handler %)))
                                        (card-for-ability state (:handler %)))
                                    %) cards-with-titles)
          choices-titles (map first choices-map)

this is where a nil value will leak in. i'm not sure why, but maybe we should use keep? that'll remove any cards-with-titles that aren't allowed (idk why card-for-ability fails only here and not earlier).

@NoahTheDuke
Copy link
Collaborator

jk i figured it out, it's a real dumb issue lmao, it's tied to #7564.

@NoahTheDuke
Copy link
Collaborator

Covered by #7565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overseer Matrix' UI shows additionalt blank options
2 participants
@NBKelly @NoahTheDuke